From d967bbaa92ae56692ab449f57ca74f120943e799 Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Wed, 2 Nov 2022 09:04:25 +0100 Subject: [PATCH] luci-base: http.uc: fix invoking Lua file upload callbacks In case a callback is installed from Lua code, the received callback argument is not a callable function but a resource object with a call method. Attempts to call it will leading to a `Type error: left-hand side is not a function` error. To solve this issue, invoke the internally set filehandler instead which wraps the resource if needed. Fixes: #6067 Signed-off-by: Jo-Philipp Wich --- modules/luci-base/ucode/http.uc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/luci-base/ucode/http.uc b/modules/luci-base/ucode/http.uc index b464497eac..4856c47a0d 100644 --- a/modules/luci-base/ucode/http.uc +++ b/modules/luci-base/ucode/http.uc @@ -432,7 +432,7 @@ const Class = { let data = value.fd.read(1024); let eof = (data == null || data == ''); - callback(value, data, eof); + this.filehandler(value, data, eof); if (eof) { value.fd.close(); -- 2.30.2