From 938bb8f7e3a4943b3c201df8cf03489257985de3 Mon Sep 17 00:00:00 2001 From: Julien Cassette Date: Sun, 2 Oct 2022 20:14:19 +0200 Subject: [PATCH] luci-app-ddns: fix creation of custom service (fix #4926) The `service_name` option must be empty for custom services, otherwise an error is raised in `dynamic_dns_updater.sh`. Signed-off-by: Julien Cassette (cherry picked from commit 85ff9db2bffd3d2bf119300d9297f1b524608e1b) --- .../htdocs/luci-static/resources/view/ddns/overview.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js index 4b786e83c5..28dfb44f0e 100644 --- a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js +++ b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js @@ -475,7 +475,9 @@ return view.extend({ return m.save(function() { uci.add('ddns', 'service', section_id); - uci.set('ddns', section_id, 'service_name', service_value); + if (service_value != '-') { + uci.set('ddns', section_id, 'service_name', service_value); + } uci.set('ddns', section_id, 'use_ipv6', ipv6_value); }).then(L.bind(m.children[1].renderMoreOptionsModal, m.children[1], section_id)); }; -- 2.30.2