From 7018c4fd91c675d7c72ba156667da967cc4ac11f Mon Sep 17 00:00:00 2001 From: Paul Donald Date: Wed, 23 Apr 2025 14:03:39 +0200 Subject: [PATCH] luci-mod-network: widgets shall show devices that are online as online Tunnel devices which are up, show as down, since the config being enumerated does not have access to any device status. The 'device' being enumerated is e.g. 'wireguard_wg0', a configuration for a tunnel interface, whose parent is an 'ethernet' type. That's a bug for another day. So they shall use parent device status. Signed-off-by: Paul Donald (cherry picked from commit a288354e78d4dd5872dea52bcebf7d1f91fad3b1) --- .../htdocs/luci-static/resources/view/network/interfaces.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js index 3874034e39..8b3fee4aff 100644 --- a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js +++ b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js @@ -117,7 +117,7 @@ function render_modal_status(node, ifc) { dom.content(node, [ E('img', { - 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', (dev && dev.isUp()) ? '' : '_disabled'), + 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', ifc.isUp() ? '' : '_disabled'), 'title': dev ? dev.getTypeI18n() : _('Not present') }), ifc ? render_status(E('span'), ifc, true) : E('em', _('Interface not present or not connected yet.')) @@ -343,7 +343,7 @@ return view.extend({ var dev = ifc.getDevice(); dom.content(stat, [ E('img', { - 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', (dev && dev.isUp()) ? '' : '_disabled'), + 'src': L.resource('icons/%s%s.png').format(dev ? dev.getType() : 'ethernet', ifc.isUp() ? '' : '_disabled'), 'title': dev ? dev.getTypeI18n() : _('Not present') }), render_status(E('span'), ifc, true) -- 2.30.2