From 63c146a464da4fe72a4eb82ad6fe6da826a5dd43 Mon Sep 17 00:00:00 2001 From: Rany Hany Date: Mon, 24 Nov 2025 15:00:57 +0000 Subject: [PATCH] wifi-scripts: ucode: fix wifi-vlan "network" option not working The call to netifd.set_vlan(...) had an incorrect argument order. It should be (interface, ifname, vlan) not (interface, vlan, ifname). This prevented wifi-vlan's "network" option from working as netifd was not able to find the wifi-vlan section. Fixes: https://github.com/openwrt/openwrt/issues/20705 Fixes: https://github.com/openwrt/openwrt/issues/20911 Signed-off-by: Rany Hany Link: https://github.com/openwrt/openwrt/pull/20918 Signed-off-by: Robert Marko --- .../config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc index 1f1e27dbee..00aff02661 100644 --- a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc +++ b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc @@ -288,7 +288,7 @@ function iface_vlan(interface, config, vlans) { if (vlan.config.name && vlan.config.vid) { let ifname = `${config.ifname}-${vlan.config.name}`; file.write(`${vlan.config.vid} ${ifname}\n`); - netifd.set_vlan(interface, k, ifname); + netifd.set_vlan(interface, ifname, k); } file.close(); -- 2.30.2