From 4474f539bb737d5c333ea58c4b9176857fd77e14 Mon Sep 17 00:00:00 2001 From: Josef Schlehofer Date: Fri, 3 Oct 2025 11:34:46 +0200 Subject: [PATCH] multi-arch-test-build: run it only after the Formality check succeeds Most of the time, when people contribute to the repository for the first time (or after a longer break), the multi-arch-test-build passes, but the formality check fails and requires the contributor to make some changes. This creates unnecessary load on the CI/CD, since the multi-arch-test-build runs again even though it already passed, while other PRs are waiting for a runner. Hopefully, this change will help decrease the waiting time. Proposed changes: - Run the formality check first, and only trigger the package tests afterwards. This can be done using needs: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idneeds - Merge formal.yml into multi-arch-test-build.yml so that needs can be used. Signed-off-by: Josef Schlehofer --- .github/workflows/formal.yml | 12 ------------ .github/workflows/multi-arch-test-build.yml | 7 ++++++- 2 files changed, 6 insertions(+), 13 deletions(-) delete mode 100644 .github/workflows/formal.yml diff --git a/.github/workflows/formal.yml b/.github/workflows/formal.yml deleted file mode 100644 index 081129d6f0..0000000000 --- a/.github/workflows/formal.yml +++ /dev/null @@ -1,12 +0,0 @@ -name: Test Formalities - -on: - pull_request: - -permissions: - contents: read - -jobs: - build: - name: Test Formalities - uses: openwrt/actions-shared-workflows/.github/workflows/formal.yml@main diff --git a/.github/workflows/multi-arch-test-build.yml b/.github/workflows/multi-arch-test-build.yml index e5ac78c01a..2a78a114e6 100644 --- a/.github/workflows/multi-arch-test-build.yml +++ b/.github/workflows/multi-arch-test-build.yml @@ -1,9 +1,14 @@ -name: Feeds Package Test Build +name: Test and Build on: pull_request: jobs: + formalities: + name: Test Formalities + uses: openwrt/actions-shared-workflows/.github/workflows/formal.yml@main + build: name: Feeds Package Test Build + needs: formalities uses: openwrt/actions-shared-workflows/.github/workflows/multi-arch-test-build.yml@main -- 2.30.2