From 18c1b02bdc2080f907b125c1169f5b471c14b43c Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20H=C3=A4rdeman?= Date: Mon, 6 Oct 2025 10:47:35 +0200 Subject: [PATCH] dhcpv4: remove one more variable from dhcpv4_handle_msg() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It's only used once, and there's no lack of variables to keep track of in dhcpv4_handle_msg(). Signed-off-by: David Härdeman Link: https://github.com/openwrt/odhcpd/pull/278 Signed-off-by: Álvaro Fernández Rojas --- src/dhcpv4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index d1d975b..1a84d30 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -628,7 +628,6 @@ void dhcpv4_handle_msg(void *src_addr, void *data, size_t len, send_reply_cb_t send_reply, void *opaque) { struct dhcpv4_message *req = data; - int sock = iface->dhcpv4_event.uloop.fd; struct sockaddr_in dest_addr; struct dhcpv4_message reply = { .op = DHCPV4_OP_BOOTREPLY, @@ -862,7 +861,7 @@ void dhcpv4_handle_msg(void *src_addr, void *data, size_t len, memset(&ifr, 0, sizeof(ifr)); strncpy(ifr.ifr_name, iface->ifname, sizeof(ifr.ifr_name) - 1); - if (!ioctl(sock, SIOCGIFMTU, &ifr)) { + if (!ioctl(iface->dhcpv4_event.uloop.fd, SIOCGIFMTU, &ifr)) { uint16_t mtu = htons(ifr.ifr_mtu); dhcpv4_put(&reply, &cursor, DHCPV4_OPT_MTU, 2, &mtu); } -- 2.30.2