virtio: force vring descriptors to be allocated from lowmem
authorWill Deacon <[email protected]>
Fri, 19 Oct 2012 13:03:33 +0000 (14:03 +0100)
committerRusty Russell <[email protected]>
Mon, 22 Oct 2012 07:49:49 +0000 (18:19 +1030)
commitb92b1b89a33c172c075edccf6afb0edc41d851fd
treeb7ca705150cfa459c4daa7f0c04874839490c291
parentb9cdc88df8e63e81c723b82c286fc97f5d0dc325
virtio: force vring descriptors to be allocated from lowmem

Virtio devices may attempt to add descriptors to a virtqueue from atomic
context using GFP_ATOMIC allocation. This is problematic because such
allocations can fall outside of the lowmem mapping, causing virt_to_phys
to report bogus physical addresses which are subsequently passed to
userspace via the buffers for the virtual device.

This patch masks out __GFP_HIGH and __GFP_HIGHMEM from the requested
flags when allocating descriptors for a virtqueue. If an atomic
allocation is requested and later fails, we will return -ENOSPC which
will be handled by the driver.

Cc: [email protected]
Cc: Sasha Levin <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
drivers/virtio/virtio_ring.c