fix for account_group_exec_runtime(), make sure ->signal can't be freed under rq...
authorOleg Nesterov <[email protected]>
Mon, 10 Nov 2008 14:39:30 +0000 (15:39 +0100)
committerIngo Molnar <[email protected]>
Tue, 11 Nov 2008 07:01:43 +0000 (08:01 +0100)
commitad474caca3e2a0550b7ce0706527ad5ab389a4d4
tree6d4e5cbcee3a85230317a33d66655ece0c873f5c
parent5ac5c4d604bf894ef672a7971d03fefdc7ea7e49
fix for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock

Impact: fix hang/crash on ia64 under high load

This is ugly, but the simplest patch by far.

Unlike other similar routines, account_group_exec_runtime() could be
called "implicitly" from within scheduler after exit_notify(). This
means we can race with the parent doing release_task(), we can't just
check ->signal != NULL.

Change __exit_signal() to do spin_unlock_wait(&task_rq(tsk)->lock)
before __cleanup_signal() to make sure ->signal can't be freed under
task_rq(tsk)->lock. Note that task_rq_unlock_wait() doesn't care
about the case when tsk changes cpu/rq under us, this should be OK.

Thanks to Ingo who nacked my previous buggy patch.

Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Reported-by: Doug Chapman <[email protected]>
include/linux/sched.h
kernel/exit.c
kernel/sched.c