net: add missing bh_unlock_sock() calls
authorEric Dumazet <[email protected]>
Wed, 2 Nov 2011 12:42:56 +0000 (12:42 +0000)
committerDavid S. Miller <[email protected]>
Thu, 3 Nov 2011 22:06:18 +0000 (18:06 -0400)
commit918eb39962dfff9490a43cd08176b962cacc7978
tree53275f3622cf13f57296481a556c47dd5d92f16f
parente2e210c0238eb7073e07af503ae743fa53977120
net: add missing bh_unlock_sock() calls

Simon Kirby reported lockdep warnings and following messages :

[104661.897577] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

[104661.923653] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

Problem comes from commit 0e734419
(ipv4: Use inet_csk_route_child_sock() in DCCP and TCP.)

If inet_csk_route_child_sock() returns NULL, we should release socket
lock before freeing it.

Another lock imbalance exists if __inet_inherit_port() returns an error
since commit 093d282321da ( tproxy: fix hash locking issue when using
port redirection in __inet_inherit_port()) a backport is also needed for
>= 2.6.37 kernels.

Reported-by: Simon Kirby <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Tested-by: Eric Dumazet <[email protected]>
CC: Balazs Scheidler <[email protected]>
CC: KOVACS Krisztian <[email protected]>
Reviewed-by: Thomas Gleixner <[email protected]>
Tested-by: Simon Kirby <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/dccp/ipv4.c
net/ipv4/tcp_ipv4.c