cgroup: Remove task_lock() from cgroup_post_fork()
authorFrederic Weisbecker <[email protected]>
Fri, 23 Dec 2011 03:25:23 +0000 (04:25 +0100)
committerTejun Heo <[email protected]>
Tue, 27 Dec 2011 17:05:20 +0000 (09:05 -0800)
commit7e3aa30ac8c904a706518b725c451bb486daaae9
tree1a6ad0678271d1cba5eba2fcafcbfa71b4e4c66d
parentc6ca57500c23d57a4ccec9874b6a3c99c297e1b5
cgroup: Remove task_lock() from cgroup_post_fork()

cgroup_post_fork() is protected between threadgroup_change_begin()
and threadgroup_change_end() against concurrent changes of the
child's css_set in cgroup_task_migrate(). Also the child can't
exit and call cgroup_exit() at this stage, this means it's css_set
can't be changed with init_css_set concurrently.

For these reasons, we don't need to hold task_lock() on the child
because it's css_set can only remain stable in this place.

Let's remove the lock there.

v2: Update comment to explain that we are safe against
cgroup_exit()

Signed-off-by: Frederic Weisbecker <[email protected]>
Acked-by: Li Zefan <[email protected]>
Signed-off-by: Tejun Heo <[email protected]>
Cc: Containers <[email protected]>
Cc: Cgroups <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Paul Menage <[email protected]>
Cc: Mandeep Singh Baines <[email protected]>
kernel/cgroup.c