memcg: allocate memory cgroup structures in local nodes
authorAndi Kleen <[email protected]>
Wed, 11 May 2011 22:13:35 +0000 (15:13 -0700)
committerLinus Torvalds <[email protected]>
Thu, 12 May 2011 01:50:45 +0000 (18:50 -0700)
commit21a3c9646873ae0919415d635b671d6a58758ede
treefa91720382d748b9d01f2dc48ed198bdfc3290cb
parentee85c2e1454603ebb9f8d87223ac79dcdc87fa32
memcg: allocate memory cgroup structures in local nodes

Commit dde79e005a769 ("page_cgroup: reduce allocation overhead for
page_cgroup array for CONFIG_SPARSEMEM") added a regression that the
memory cgroup data structures all end up in node 0 because the first
attempt at allocating them would not pass in a node hint.  Since the
initialization runs on CPU #0 it would all end up node 0.  This is a
problem on large memory systems, where node 0 would lose a lot of
memory.

Change the alloc_pages_exact() to alloc_pages_exact_nid().  This will
still fall back to other nodes if not enough memory is available.

 [ RED-PEN: right now it would fall back first before trying
   vmalloc_node.  Probably not the best strategy ...  But I left it like
   that for now. ]

Signed-off-by: Andi Kleen <[email protected]>
Reported-by: Doug Nelson
Cc: David Rientjes <[email protected]>
Reviewed-by: Michal Hocko <[email protected]>
Cc: Dave Hansen <[email protected]>
Acked-by: Balbir Singh <[email protected]>
Acked-by: Johannes Weiner <[email protected]>
Reviewed-by: KOSAKI Motohiro <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/page_cgroup.c