staging: rtl8188eu: rtw_efuse.c: Remove unnecessary function declaration

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:rtl8188eu: Assign rtl8188e_Efuse_WordEnableDataWrite() to ->Efuse_WordEnableDataWrite

Assign rtl8188e_Efuse_WordEnableDataWrite() to ->Efuse_WordEnableDataWrite
instead of going through many functions.

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging:rtl8188eu:assign hal_EfusePgPacketWrite_8188e() to ->Efuse_PgPacketWrite

assign hal_EfusePgPacketWrite_8188e() to ->Efuse_PgPacketWrite directly
instead of going through many functions.

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: assign hal_EfusePgPacketRead_8188e() to ->Efuse_PgPacketRead

assign hal_EfusePgPacketRead_8188e() to ->Efuse_PgPacketRead directly
instead of going through many functions.

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Rename Hal_EFUSEGetEfuseDefinition88E()

Rename Hal_EFUSEGetEfuseDefinition88E() to rtl8188e_EFUSE_GetEfuseDefinition()
and remove original rtl8188e_EFUSE_GetEfuseDefinition(), so that driver can call
Hal_EFUSEGetEfuseDefinition88E() directly without going through
rtl8188e_EFUSE_GetEfuseDefinition().

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Remove function Hal_EFUSEGetEfuseDefinition_Pseudo88E()

Definition of Hal_EFUSEGetEfuseDefinition_Pseudo88E() is identical
to Hal_EFUSEGetEfuseDefinition88E().

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Remove unused function Hal_EfuseGetCurrentSize_Pseudo()

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Remove rtl8188e_EfuseGetCurrentSize()

rtl8188e_EfuseGetCurrentSize() checks bool bPseudoTest and then calls suitable
function to get efuse size, hal_EfuseGetCurrentSize_8188e() also does same thing.
So use hal_EfuseGetCurrentSize_8188e() and drop rtl8188e_EfuseGetCurrentSize().

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Remove unused function ReadEFuse_Pseudo()

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Remove rtl8188e_ReadEFuse()

rtl8188e_ReadEFuse() checks bool bPseudoTest and then calls suitable
function to read Fuse, ReadEFuseByIC() also does same thing.
So use ReadEFuseByIC() and drop rtl8188e_ReadEFuse().

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8188eu: Rename hal_EfusePowerSwitch_RTL8188E()

Rename hal_EfusePowerSwitch_RTL8188E() to rtl8188e_EfusePowerSwitch() and
remove original rtl8188e_EfusePowerSwitch(), so that driver can call
hal_EfusePowerSwitch_RTL8188E() directly without going through
rtl8188e_EfusePowerSwitch().

Signed-off-by: navin patidar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Qos.c: fix checkpatch errors: whitespaces

This patch improves coding style in Qos.c
Whitespaces according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Qos.c: fix checkpatch errors: comments

This patch improves coding style in Qos.c
Comments according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Queue.h: fix checkpatch errors: whitespaces

This patch improves coding style in Queue.h
Whitespaces according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Queue.h: fix checkpatch errors: brackets

This patch improves coding style in Queue.h:
Brackets according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Queue.h: fix checkpatch errors: comments

This patch improves coding style in Queue.h
Comments according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Prototypes.h: fix checkpatch errors: whitespaces

This patch improves coding style in Prototypes.h:
Whitespaces according to the coding guideline

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: bcm: Prototypes.h: fix checkpatch errors: blank lines

This patch improves coding style in Prototypes.h:
Exactly one blank line after each declaration

Signed-off-by: Martin Gumbrecht <[email protected]>
Signed-off-by: Christian Bay <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: comedi: describe struct comedi_async

Describe `struct comedi_async` in kerneldoc format.  Expand on the
members involved in reading/writing the buffer.

Signed-off-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: serqt_usb2: fixed blank line style warning in serqt_usb2.c

This is a patch to the serqt_usb2.c file that fixes the following
warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Vincent Heuken <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging/lustre: disable virtual block device for 64K pages

The lustre virtual block device cannot handle 64K pages and fails at compile
time. To avoid running into this error, let's disable the Kconfig option
for this driver in cases it doesn't support.

Reported-by: Dann Frazier <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

v2 staging: translates 3 comments into english in HalBtc8812a1Ant.c

Signed-off-by: Toralf Förster <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: comedi: ni_daq_700: add AI range and input mode switching

Add support for switching the input range and the single-ended/
differential input mode for the AI subdevice.  We needed to clear the
FIFO of data before the conversion to handle card mode switching
glitches.

[ Minor whitespace fixes and driver comment reformatting.  - Ian ]

Signed-off-by: Fred Brooks <[email protected]>
Signed-off-by: Ian Abbott <[email protected]>
Reviewed-by: H Hartley Sweeten <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: dgap: make dgap_found_board() return a brd pointer

Make dgap_found_board() return a brd pointer and that brd pointer
assign to dgap_board[] in the end of the dgap_init_one().

Signed-off-by: Daeseok Youn <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging/cptm1217: fix checkpatch warnings about else clause

Signed-off-by: Evgeny Budilovsky <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: alarm-dev: Set the license to GPL

Adding "GPL" license to fix a warning while compiling as
module.

CC: Brian Swetland <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: crystalhd: remove driver

The driver hasn't had significant work done on it for a long time.
Broadcom has EOLed the hardware and is no longer selling it. There are
probably very few people still using it. So remove the driver.

Signed-off-by: Kristina Martšenko <[email protected]>
Cc: Naren Sankar <[email protected]>
Cc: Jarod Wilson <[email protected]>
Cc: Scott Davilla <[email protected]>
Cc: Manu Abraham <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: ion: fixup invalid kfree() calls on heap destroy

I've noticed that the last commit to ion_system_heap.c ('staging: ion:
optimize struct ion_system_heap') has an omission, so an invalid kfree()
gets called on ion_system_heap_destroy(). As ION system heap is never
destroyed until system shutdown, it may not cause any harm, but should
be fixed. I should have caught this before the merge, my bad.

Signed-off-by: Heesub Shin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: alarm-dev: Support to Compile as Module

Currently this alarm-dev can be compiles only as built in
driver. This adds support to compile it as module as well which is in
planned activity (See drivers/staging/android/TODO)

CC: Brian Swetland <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

alarmtimer: Export symbols of alarmtimer_get_rtcdev

Export symbol of alarmtimer_get_rtcdev so that it is used by
any driver when built as module like,
drivers/staging/android/alarm-dev.c.

CC: John Stultz <[email protected]>
CC: Marcus Gelderie <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2sta:checkpatch: Insert blank lines

This patch inserts blank lines after declarations to avoid checkpatch
warnings.

After our fixes in 'wlan-ng/prism2sta' there is still a checkpatch
warning about prefering 'ether_addr_copy' instead of 'memcpy'
remaining.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
Reviewed-by: Josh Triplett <[email protected]>
CC: Tugce Sirin <[email protected]>
CC: Himangi Saraogi <[email protected]>
CC: Paul Gortmaker <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: Neil Armstrong <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2sta:checkpatch: Fix string split

This patch fixes a warning of checkpatch about string splitting.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
CC: Tugce Sirin <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: Neil Armstrong <[email protected]>
CC: Paul Gortmaker <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2mib:checkpatch: Fix string split

This patch fixes a warning of checkpatch about string splitting.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
Reviewed-by: Josh Triplett <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: Himangi Saraogi <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2mgmt:checkpatch: Insert blank line

This patch inserts a blank line after a declaration to avoid checkpatch
warning.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
Meh-by: Josh Triplett <[email protected]>
CC: Himangi Saraogi <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2mgmt:checkpatch: Fix string split

This patch fixes all warnings of checkpatch about string splitting.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
CC: Himangi Saraogi <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: [email protected]
CC: [email protected]
Reviewed-by: Josh Triplett <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

wlan-ng/prism2mgmt:checkpatch: Fix long lines

This patch fixes all warnings of checkpatch about lines over 80
characters.

Signed-off-by: Johannes Stadlinger <[email protected]>
Signed-off-by: Maximilian Eschenbacher <[email protected]>
CC: [email protected]
CC: Himangi Saraogi <[email protected]>
CC: Vitaly Osipov <[email protected]>
CC: [email protected]
CC: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging/wlags49_h2: checkpatch: line over 80 characters

Signed-off-by: Stephan Gabert <[email protected]>
Signed-off-by: Nicolas Pfeiffer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging/wlags49_h2: checkpatch: added spaces around equal sign

Hereby the checkpatch message
  ERROR: spaces required around that '=' (ctx:VxV)
gets resolved
and the neighboring equal signs are positioned in the same column.

Signed-off-by: Stephan Gabert <[email protected]>
Signed-off-by: Nicolas Pfeiffer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging/wlags49_h2: checkpatch: including <linux/*.h> instead of <asm/*.h>

As warned by checkpatch.pl, one should use #include <linux/io.h>
instead of #include <asm/io.h> and #include <linux/bitops.h>
instead of #include <asm/bitops.h>.

Signed-off-by: Stephan Gabert <[email protected]>
Signed-off-by: Nicolas Pfeiffer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: ldlm: ldlm_lib.c removed unecessary space after function name

- this fixes "WARNING: space prohibited between function name and open
  parenthesis '("

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: lustre: ldlm: ldlm_lib.c - removed unnecessary braces

- this change fixes "WARNING: braces {} are not necessary for single
  statement blocks"

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: lustre: fld: lproc_fld.c fixed warning

fixed warning "WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable"

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: lustre: fld: lproc_fld.c fixed warning

fixed warning for line over 80 characters by moving the struct init
onto a diff line.

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: ldlm: ldlm_resource.c replace obsolete function with kstrtoul()

- this change fixes the warning "WARNING: simple_strtoul is obsolete, use
kstrtoul instead"
- removed the unused var 'end' as this is no longer required for
  kstrtoul()

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: ldlm: ldlm_resource.c removed unecessary braces

- this fixed the "WARNING: braces {} are not necessary for
  single statement blocks"

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging : lustre : lustre : fid : lproc_fid.c: fixed warning

fixed warning for line over 80 characters by moving the initilation
onto a diff line.

Signed-off-by: Anil Belur <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue

Signed-off-by: Andrey Skvortsov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers

Signed-off-by: Andrey Skvortsov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

Signed-off-by: Andrey Skvortsov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: Remove useless "default N" lines

Two Kconfig entries default to (uppercase) "N". It was clearly intended
to use "default n". But since (lowercase) "n" is the default anyway,
these lines might as well be removed.

Reported-by: Martin Walch <[email protected]>
Signed-off-by: Paul Bolle <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: sep: Fix checkpatch.pl warnings

Fix checkpatch.pl warnings:
Missing blank line after Declarations

Signed-off-by: Benedict Boerger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging:tidspbridge Fix minor checkpatch.pl warning

Fixed checkpatch "WARNING: Missing a blank line after declarations"

Signed-off-by: Adithya Krishnamurthy <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging cxt1e1: refactored ring buffer dump functions to avoid sparse warnings

Sparse spit out these warnings:

drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block
drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block

The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is
held. musycc_dump_[rt]xbuffer_ring() take the lock.

Signed-off-by: Wolfgang Ocker <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: ced1401: userspace: use1401.c: Cleaning up if statement that always evaluates to true

Unsigned variable can't be negative so it is unnecessary to test it.

Signed-off-by: Rickard Strandqvist <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: rtl8192e: dot11d: Fixed printk coding style issues

Replaced 'printk' with 'netdev_' function

Signed-off-by: A Raghavendra Rao <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: r8192ee: avoid leaking format string

This makes sure a format string cannot leak into the work queue name nor
the printk buffer.

Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: unisys: Remove trailing semicolon from macro

This patch removed trailing semicolon from macro in guestlinuxdebug.h

Signed-off-by: Masanari Iida <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/staging/speakup/main: fixed jiffie comparison

speakup_key() used manual comparison of jiffies to determine the time
since the last keypress, replaced it with time_after()

Signed-off-by: Robin Schroer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: line6: do not return 0 from probe if no initialization done

There is a strange "return 0" in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

Staging: dgnc: fixed brace coding style issue in dgnc_driver.c

This is a patch to the dgnc_driver.c file that fixes the following
error:
ERROR: open brace '{' following function declarations go on
the next line

Signed-off-by: Vincent Heuken <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: wlags49_h2: avoid PROFILE_ALL_BRANCHES warnings

Using an 'if()' inside of an 'extern inline' function causes
a gcc warning when CONFIG_PROFILE_ALL_BRANCHES is set every
time the function is called, which gets very noisy:

In file included from /git/arm-soc/drivers/staging/wlags49_h2/wl_wext.c:73:0:
drivers/staging/wlags49_h2/wl_internal.h:1035:216: warning: '______f' is static but declared in inline function 'wl_act_int_off' which is not static [enabled by default]
  if(lp->is_handling_int == WL_HANDLING_INT) {

Fortunately there is a trivial workaround, so we can avoid
the problem by making the functions in question 'static inline'
rather than 'extern inline'.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Henk de Groot <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: lirc: remove sa1100 support

The LIRC support for sa1100 appears to have never worked
because it relies on header files that have never been
present in git history. Actually trying to build the
driver on an ARM sa1100 kernel fails, so let's just remove
the broken support.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Jarod Wilson <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Tuomas Tynkkynen <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: sn9c102 depends on USB

If the USB code is a loadable module, this driver cannot
be built-in. This adds an explicit dependency on CONFIG_USB
so that Kconfig can force sn9c102 to be a module in this case.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Luca Risolia <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/staging/bcm/Misc: style: removed void returns

Signed-off-by: Robin Schroer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/staging/bcm/Misc: style: removed duplicate parentheses

Signed-off-by: Robin Schroer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/staging/bcm/Misc: style: added blank lines after declarations

Signed-off-by: Robin Schroer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: bcm: Remove unnecessary parentheses

This patch remove unnecessary parentheses in PHSModule.c

Signed-off-by: Masanari Iida <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

Array 'SigBuff' is filled incompletely.
Someone forget to multiply for the sizeof type.

This was partly found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

drivers/staging/bcm: Added a space after a comma.

Signed-off-by: Chuong Ngo <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: skein: fix sparse warning for static arrays

This patch fixes the following sparse warnings:

skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static?
skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static?
skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static?
skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static?
skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static?
skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static?
skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static?
skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static?
skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static?
skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static?
skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static?
skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static?
skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static?

by declaring the initialization vectors in question as static.  The header
skein_iv.h is only included by skein.c

Signed-off-by: James A Shackleford <[email protected]>
Acked-by: Jason Cooper <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8821ae: fix sparse warning for static declarations

This commit fixes the following sparse warnings in ps.c:
  - 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static?
  - 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be static?

Signed-off-by: Marcus Farkas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8712: replace kmalloc(..., sizeof(T))

As suggested by Andy Shevchenko on driverdev-devel, replace
v = ... sizeof(struct type_of_v) -> sizeof(*v)

Based on a cocci patch along the lines of

@@
type T;
expression E;
identifier V;
@@

T *V;
...
- V = kmalloc(sizeof(T), E);
+ V = kmalloc(sizeof(*V), E);

@@
type T;
expression E;
identifier V;
@@

T *V;
...
- V = kzalloc(sizeof(T), E);
+ V = kzalloc(sizeof(*V), E);

Signed-off-by: Vitaly Osipov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

The same code regardless of the outcome of the if statement.
And clean up another duplicate line of code.

Signed-off-by: Rickard Strandqvist <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8712, rtl8712: avoid lots of build warnings

The rtl8712 driver has an 'extern inline' function that contains an
'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES
overriding the definition of 'if':

drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default]

This changes the driver to use 'static inline' instead, which happens
to be the correct annotation anyway.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Larry Finger <[email protected]>
Cc: Florian Schilhabel <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8712: Remove useless variable 'fw_found'

The net device only exists when firmware is loaded successfully.
Firmware presence variable is only used through r871xu_dev_remove() and
this function already checks for net device existence.

Signed-off-by: Thomas Vegas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: rtl8712: Fix oops on dongle removal if firmware is not available

When firmware is not available, net device is not created. Upon
disconnect, we must check for net device existence before trying to
release net device private data.

Signed-off-by: Thomas Vegas <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: coding style: use C89 comments

fix coding style: use C89 comments, not C99

Signed-off-by: Merlin Chlosta <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: remove unnecessary typedef struct.

Remove a totally unnecessary typedef and rename it to lowercase.
This is more readable now.

Signed-off-by: Martin Kepplinger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: replace C99 style comments

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: fix sparse warning for static declarations

This patch fixes the following sparse warnings:

iwctl.c:76:22: warning: symbol 'iwctl_get_wireless_stats' was not declared. Should it be static?
iwctl.c:118:5: warning: symbol 'iwctl_giwname' was not declared. Should it be static?
iwctl.c:131:5: warning: symbol 'iwctl_siwscan' was not declared. Should it be static?
iwctl.c:192:5: warning: symbol 'iwctl_giwscan' was not declared. Should it be static?
iwctl.c:344:5: warning: symbol 'iwctl_siwfreq' was not declared. Should it be static?
iwctl.c:390:5: warning: symbol 'iwctl_giwfreq' was not declared. Should it be static?
iwctl.c:420:5: warning: symbol 'iwctl_siwmode' was not declared. Should it be static?
iwctl.c:486:5: warning: symbol 'iwctl_giwmode' was not declared. Should it be static?
iwctl.c:520:5: warning: symbol 'iwctl_giwrange' was not declared. Should it be static?
iwctl.c:626:5: warning: symbol 'iwctl_siwap' was not declared. Should it be static?
iwctl.c:684:5: warning: symbol 'iwctl_giwap' was not declared. Should it be static?
iwctl.c:711:5: warning: symbol 'iwctl_giwaplist' was not declared. Should it be static?
iwctl.c:784:5: warning: symbol 'iwctl_siwessid' was not declared. Should it be static?
iwctl.c:893:5: warning: symbol 'iwctl_giwessid' was not declared. Should it be static?
iwctl.c:923:5: warning: symbol 'iwctl_siwrate' was not declared. Should it be static?
iwctl.c:1004:5: warning: symbol 'iwctl_giwrate' was not declared. Should it be static?
iwctl.c:1049:5: warning: symbol 'iwctl_siwrts' was not declared. Should it be static?
iwctl.c:1077:5: warning: symbol 'iwctl_giwrts' was not declared. Should it be static?
iwctl.c:1096:5: warning: symbol 'iwctl_siwfrag' was not declared. Should it be static?
iwctl.c:1123:5: warning: symbol 'iwctl_giwfrag' was not declared. Should it be static?
iwctl.c:1141:5: warning: symbol 'iwctl_siwretry' was not declared. Should it be static?
iwctl.c:1176:5: warning: symbol 'iwctl_giwretry' was not declared. Should it be static?
iwctl.c:1205:5: warning: symbol 'iwctl_siwencode' was not declared. Should it be static?
iwctl.c:1336:5: warning: symbol 'iwctl_giwencode' was not declared. Should it be static?
iwctl.c:1398:5: warning: symbol 'iwctl_siwpower' was not declared. Should it be static?
iwctl.c:1448:5: warning: symbol 'iwctl_giwpower' was not declared. Should it be static?
iwctl.c:1478:5: warning: symbol 'iwctl_giwsens' was not declared. Should it be static?
iwctl.c:1502:5: warning: symbol 'iwctl_siwauth' was not declared. Should it be static?
iwctl.c:1603:5: warning: symbol 'iwctl_giwauth' was not declared. Should it be static?
iwctl.c:1611:5: warning: symbol 'iwctl_siwgenie' was not declared. Should it be static?
iwctl.c:1644:5: warning: symbol 'iwctl_giwgenie' was not declared. Should it be static?
iwctl.c:1669:5: warning: symbol 'iwctl_siwencodeext' was not declared. Should it be static?
iwctl.c:1783:5: warning: symbol 'iwctl_giwencodeext' was not declared. Should it be static?
iwctl.c:1791:5: warning: symbol 'iwctl_siwmlme' was not declared. Should it be static?
iwctl.c:1900:21: warning: symbol 'iwctl_private_args' was not declared. Should it be static?
iwctl.c:1906:33: warning: symbol 'iwctl_handler_def' was not declared. Should it be static?

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: update iwctl_private_args extern declaration

Update declaration of iwctl_private_args to match definition in iwctl.c

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: update out-of-date function declaration

The function iwctl_siwscan() is defined in iwctl.c as:
int iwctl_siwscan(struct net_device *dev,
  struct iw_request_info *info,
  struct iw_point *wrq,
  char *extra)
{
  ...

This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in the
function declaration matches the definition.

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: fix sparse warning for static declarations

This patch fixes the following sparse warnings:

dpc.c:65:21: warning: symbol 'acbyRxRate' was not declared. Should it be static?
dpc.c:272:9: warning: symbol 'MngWorkItem' was not declared. Should it be static?
dpc.c:288:1: warning: symbol 'device_receive_frame' was not declared. Should it be static?

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6655: fix sparse warning "cast removes address space of expression"

Add missing __user macro to second parameter of ethtool_ioctl().
This removes the need for the offending (void *) cast of the user space pointer
rq->ifr_data.

Signed-off-by: James A Shackleford <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: gdm724x: Added blank lines after declarations in gdm_lte.c

This patch fixes following checkpatch.pl warning:
WARNING: Missing a blank line after declarations in gdm_lte.c

Signed-off-by: Scott Weir <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename BBuGetFrameTime to vnt_get_frame_time

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename BBvCalculateParameter to vnt_get_phy_field

The function returns the phy fields rename to vnt_get_phy_field

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename FIRMWAREbCheckVersion to vnt_check_firmware_version

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename FIRMWAREbBrach2Sram to vnt_firmware_branch_to_sram

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename FIRMWAREbDownload to vnt_download_firmware

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: firmware.c replace DBG_PRT debug messages

Replace with dev_dbg

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: FIRMWAREbCheckVersion remove camel case

camel case changes
pDevice -> priv
ntStatus -> status

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: FIRMWAREbBrach2Sram remove camel case

camel case changes
pDevice -> priv
NdisStatus -> status

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: FIRMWAREbDownload remove camel case

camel case changes
pDevice -> priv
NdisStatus -> status
pBuffer -> buffer
wLength -> length

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename PSbIsNextTBTTWakeUp to vnt_next_tbtt_wakeup

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename PSvDisablePowerSaving to vnt_disable_power_saving

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: rename PSvEnablePowerSaving to vnt_enable_power_saving

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: PSbIsNextTBTTWakeUp remove camel case

camel case changes
pDevice -> priv
pMgmt -> mgmt
bWakeup -> wake_up

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: PSvDisablePowerSaving remove camel case

pDevice -> priv

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

staging: vt6656: PSvEnablePowerSaving remove camel case

camel case changes
pDevice -> priv
wListenInterval -> listen_interval
pMgmt -> mgmt
wAID -> aid

Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>