build: require CMake >= 3.10 due to dropped legacy support
CMake version 4.0 and later require minimum version of 3.5 or later.
Update to minimum version 3.10 which is the last not deprecated minimum
version.
CMake 3.10 was released in November 2017 and is included in Ubuntu 18.04.
Signed-off-by: Hauke Mehrtens <[email protected]>
umbim: fix invalid mbim message string encoding
Strings in mbim messages have to follow these formatting rules:
- 4 byte alignment, padded if not.
- utf-16 little endian.
Fixes:
- mbim connect fails with more than 1 string parameter (apn/user/pass)
when they are not 4 byte aligned.
Signed-off-by: Daniel Danzberger <[email protected]>
umbim: fix compilation with GCC 10
When building umbim with GCC 10, a bunch of these errors appear:
cli.c: In function 'mbim_device_caps_response':
cli.c:55:29: error: taking address of packed member of 'struct mbim_basic_connect_device_caps_r' may result in an unaligned pointer value [-Werror=address-of-packed-member]
55 | deviceid = mbim_get_string(&caps->deviceid, buffer);
| ^~~~~~~~~~~~~~~
Fix them by disabling padding between fields of struct mbim_string.
Acked-by: John Crispin <[email protected]>
Signed-off-by: Stijn Tintel <[email protected]>
umbim: add home provider query support
This adds support to query the home provider, mainly for debugging and
information purposes.
Signed-off-by: Ingo Feinerer <[email protected]>
Reviewed-by: Bjørn Mork <[email protected]>
Iron out all extra compiler warnings
mbim-msg.c:83:17: error: comparison between signed and unsigned integer expressions
cli.c:50:10: error: comparison between signed and unsigned integer expressions
cli.c:81:10: error: comparison between signed and unsigned integer expressions
cli.c:104:10: error: comparison between signed and unsigned integer expressions
cli.c:140:10: error: comparison between signed and unsigned integer expressions
cli.c:154:18: error: comparison between signed and unsigned integer expressions
cli.c:171:10: error: comparison between signed and unsigned integer expressions
cli.c:194:10: error: comparison between signed and unsigned integer expressions
cli.c:223:10: error: comparison between signed and unsigned integer expressions
cli.c:229:17: error: comparison between signed and unsigned integer expressions
cli.c:241:17: error: comparison between signed and unsigned integer expressions
cli.c:247:17: error: comparison between signed and unsigned integer expressions
cli.c:259:17: error: comparison between signed and unsigned integer expressions
cli.c:272:10: error: comparison between signed and unsigned integer expressions
cli.c:549:16: error: comparison between signed and unsigned integer expressions
mbim-dev.c:68:21: error: comparison between signed and unsigned integer expressions
mbim-dev.c:97:10: error: comparison between signed and unsigned integer expressions
Reviewed-by: Bjørn Mork <[email protected]>
Signed-off-by: Petr Štetiar <[email protected]>
Enable extra compiler checks
Let's enforce additional automatic checks enforced by the compiler in
order to catch possible errors during compilation.
Reviewed-by: Bjørn Mork <[email protected]>
Signed-off-by: Petr Štetiar <[email protected]>
mbim-proxy support
This adds support for the libmbim-glib "mbim-proxy", allowing umbim to access
a device under ModemManager control. The feature is mostly useful for debugging
and development purposes, and is therefore disabled by default.
Signed-off-by: Bjørn Mork <[email protected]>
umbim: add registration set support
This implements the MBIM automatic registration mode to let the function
select the best provider network.
Signed-off-by: Ingo Feinerer <[email protected]>
Reviewed-by: Bjørn Mork <[email protected]>
add radio_state set/query support
Signed-off-by: Bjørn Mork <[email protected]>
get buffer size from driver
Signed-off-by: Bjørn Mork <[email protected]>
dynamically allocate buffer
Signed-off-by: Bjørn Mork <[email protected]>
support non default ip-types
Signed-off-by: Bjørn Mork <[email protected]>
support IPv6 configuration
Signed-off-by: Bjørn Mork <[email protected]>
fix IP configuration prefix output
Signed-off-by: Bjørn Mork <[email protected]>
add command_id to verbose output
Signed-off-by: Bjørn Mork <[email protected]>
avoid parsing InformationBuffer unless status is "success"
The MBIM specification requires that the InformationBuffer
is empty unless the status field is MBIM_STATUS_SUCCESS,
except for 4 explicit combinations of status code and
command id.
Avoid calling the reply handler if the status code is
non-zero and the information buffer is empty.
Signed-off-by: Bjørn Mork <[email protected]>
add command done status to verbose output
Signed-off-by: Bjørn Mork <[email protected]>
fix subscriber response segfault
Signed-off-by: Bjørn Mork <[email protected]>
fix build for 64 bit systems
Signed-off-by: John Crispin <[email protected]>
cleanup authprotocol handling
Signed-off-by: John Crispin <[email protected]>
add support for authproto/username/password
Signed-off-by: John Crispin <[email protected]>
sanitize pincode properly
Signed-off-by: John Crispin <[email protected]>