From: Jo-Philipp Wich <jo@mein.io>
Date: Tue, 2 Oct 2018 17:20:53 +0000 (+0200)
Subject: luci-app-nlbwmon: fix nil value concat
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=fb859e602b1254c5d199d7f641f6b6717edd01cf;p=project%2Fluci.git

luci-app-nlbwmon: fix nil value concat

Do not concatenate the yet undefined mtime variable to avoid a controller
error with backtrace.

Fixes: b3642f476 ("luci-app-nlbwmon: add proper file names for json and csv exports.")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---

diff --git a/applications/luci-app-nlbwmon/luasrc/controller/nlbw.lua b/applications/luci-app-nlbwmon/luasrc/controller/nlbw.lua
index d50b77d0f4..0d15bea648 100644
--- a/applications/luci-app-nlbwmon/luasrc/controller/nlbw.lua
+++ b/applications/luci-app-nlbwmon/luasrc/controller/nlbw.lua
@@ -57,8 +57,6 @@ function action_data()
 		json = "application/json"
 	}
 
-	local filename = "data." .. mtype
-
 	local args = { }
 	local mtype = http.formvalue("type") or "json"
 	local delim = http.formvalue("delim") or ","
@@ -94,7 +92,7 @@ function action_data()
 	end
 
 	http.prepare_content(types[mtype])
-	http.header("Content-Disposition", "attachment; filename=\"%s\"" % filename)
+	http.header("Content-Disposition", "attachment; filename=\"data.%s\"" % mtype)
 	exec("/usr/sbin/nlbw", args, http.write)
 end