From: Guoxin Pu <pugokushin@gmail.com>
Date: Thu, 5 Jun 2025 10:40:00 +0000 (+0800)
Subject: luci-app-ddns: no implicit interface when ip_source=interface
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=ed8c1538869e2482d8d9b1ed1f680efa238b598f;p=project%2Fluci.git

luci-app-ddns: no implicit interface when ip_source=interface

The DDNS service attribute "interface" is for hotplug.d hook to bring up
and down DDNS updater(s) on ifup and ifdown events for an OpenWrt
"interface", not to be confused with attribute "ip_interface" which defines
the physical interface to get IP from.

With this change, the DDNS configuration service.xxx.interface is no longer
derived from the physical interface name (duplicated from ip_interface to be
specific) when ip_source=interface, and as a result, the interface must be set
explicitly.

Signed-off-by: Guoxin Pu <pugokushin@gmail.com>
(cherry picked from commit e6b26d1e07c41dfd520a2e8ef67ec14b6118f288)
---

diff --git a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
index 8c86bf2179..f6e7649e18 100644
--- a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
+++ b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
@@ -868,11 +868,11 @@ return view.extend({
 					o.default = 'wan';
 					o.depends("ip_source", "web");
 					o.depends("ip_source", "script");
+					o.depends("ip_source", "interface");
 
 					o = s.taboption('advanced', form.DummyValue, '_interface',
 						_("Event Network"),
 						_("Network on which the ddns-updater scripts will be started"));
-					o.depends("ip_source", "interface");
 					o.depends("ip_source", "network");
 					o.forcewrite = true;
 					o.modalonly = true;