From: Sven Eckelmann Date: Thu, 9 Oct 2025 11:56:19 +0000 (+0200) Subject: realtek: Switch booleans in rtl838x_port to single bits X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=e696f39da816136746e37fa1a2f59349ddac28db;p=openwrt%2Fstaging%2Fnbd.git realtek: Switch booleans in rtl838x_port to single bits In upstream kernel, it is not well received to use a lot of simple booleans in structs. It is preferred to use 1-bit bitfields [1] and consolidate the booleans together. [1] https://www.kernel.org/doc/html/v6.16/process/coding-style.html#using-bool Signed-off-by: Sven Eckelmann Link: https://github.com/openwrt/openwrt/pull/20360 Signed-off-by: Robert Marko --- diff --git a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl838x.h b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl838x.h index 9102442231..42b1911d9e 100644 --- a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl838x.h +++ b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl838x.h @@ -680,14 +680,14 @@ struct rtldsa_counter_state { }; struct rtl838x_port { - bool enable; + bool enable:1; + bool phy_is_integrated:1; + bool is10G:1; + bool is2G5:1; u64 pm; u16 pvid; bool eee_enabled; enum phy_type phy; - bool phy_is_integrated; - bool is10G; - bool is2G5; int sds_num; int led_set; int leds_on_this_port;