From: Josef Schlehofer Date: Mon, 2 Jun 2025 11:17:12 +0000 (+0200) Subject: github: Use Markdown and slight changes to PR template X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=c623dbf30d1da13e07b6c696774b6f2f43f79f9a;p=feed%2Fpackages.git github: Use Markdown and slight changes to PR template The previous pull request was kinda not exactly tested. This one should be better and more visible. Fixes: 9a273c3e79ec1018aea4fe9bc338d679f5553bee ("github: Improve Pull Request template") Signed-off-by: Josef Schlehofer --- diff --git a/.github/pull_request_template b/.github/pull_request_template deleted file mode 100644 index caa96d4a58..0000000000 --- a/.github/pull_request_template +++ /dev/null @@ -1,19 +0,0 @@ -**Package details** - - Maintainer: @\ (find it by checking the history of the package Makefile) - Description: - -**Indication of run testing** - - OpenWrt version: - OpenWrt target/subtarget: - OpenWrt device: - -**Formalities** - - [ ] Review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines. - - If your PR contains a patch - [ ] Make sure that it can be applied by `git am` - [ ] It must be refreshed to avoid offsets, fuzzes, etc by `make package/foo/refresh V=s` - [ ] It must be in a way that it is potentially upstreamable (subject, commit description, etc.), and we must try to upstream it so we have fewer patches and fewer. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..8d1d04426a --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,32 @@ +## 📦 Package Details + +**Maintainer:** @ +(You can find this by checking the history of the package `Makefile`.) + +**Description:** + + +--- + +## 🧪 Run Testing Details + +- **OpenWrt Version:** +- **OpenWrt Target/Subtarget:** +- **OpenWrt Device:** + +--- + +## ✅ Formalities + +- [ ] I have reviewed the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines. + +### If your PR contains a patch: + +- [ ] It can be applied using `git am` +- [ ] It has been refreshed to avoid offsets, fuzzes, etc., using + ```bash + make package//refresh V=s + ``` +- [ ] It is structured in a way that it is potentially upstreamable +(e.g., subject line, commit description, etc.) +We must try to upstream patches to reduce maintenance burden.