From: Sebastian Kemper <sebastian_ml@gmx.net>
Date: Tue, 18 Dec 2018 19:53:12 +0000 (+0100)
Subject: sqlite3: remove $(FPIC)
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=c565ad271b5811be1d4aa1963326c8ec0d726b66;p=feed%2Fpackages.git

sqlite3: remove $(FPIC)

Defaulting to -fPIC is a bad idea, especially for executables (here:
sqlite3-cli). In short, there are certain security implications as well
as overhead/performance penalties. Details see:

https://wiki.gentoo.org/wiki/Project:Hardened/Position_Independent_Code_internals

The configure script is able to detect the need for PIC and adds the
flag when needed anyway (when compiling the library).

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
---

diff --git a/libs/sqlite3/Makefile b/libs/sqlite3/Makefile
index 28020e3a28..71be4e1893 100644
--- a/libs/sqlite3/Makefile
+++ b/libs/sqlite3/Makefile
@@ -75,7 +75,7 @@ $(call Package/sqlite3/Default/description)
  formats.
 endef
 
-TARGET_CFLAGS += $(FPIC) \
+TARGET_CFLAGS += \
 	-DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \
 	-DHAVE_ISNAN=1 \
 	-DHAVE_MALLOC_USABLE_SIZE=1