From: Nicolas BESNARD <nico.besnard31@gmail.com>
Date: Fri, 21 Feb 2025 08:58:17 +0000 (+0000)
Subject: odhcp6c: add failure when -E option is used without ubus support enabled
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=8d89d373f360a38777e27c09d37850cef118cd4b;p=project%2Fodhcp6c.git

odhcp6c: add failure when -E option is used without ubus support enabled

Problem: The -E option disables the state script and relies only on ubus
to emit events on state changes. But if odhcp6c is compiled without ubus
support (ENABLE_UBUS flag omitted), odhcp6c has no way to signal state
changes.

Solution: Return an error when -E flag is used and ubus support is
absent.

Signed-off-by: Nicolas BESNARD <nico.besnard31@gmail.com>
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Link: https://github.com/openwrt/odhcp6c/pull/106
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---

diff --git a/src/odhcp6c.c b/src/odhcp6c.c
index e784b56..c36e3e3 100644
--- a/src/odhcp6c.c
+++ b/src/odhcp6c.c
@@ -347,6 +347,10 @@ int main(_unused int argc, char* const argv[])
 			break;
 
 		case 'E':
+#ifndef WITH_UBUS
+			syslog(LOG_ERR, "Failed to use ubus event: ENABLE_UBUS compilation flag missing");
+			return 1;
+#endif /* WITH_UBUS */
 			script = NULL;
 			break;