From: Ansuel Smith <ansuelsmth@gmail.com>
Date: Sat, 22 Aug 2020 17:58:28 +0000 (+0200)
Subject: luci-app-ddns: fix wrong service with custom selected
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=8aac2a339aca4efec9ef5ac4b325eda2e55ea10d;p=project%2Fluci.git

luci-app-ddns: fix wrong service with custom selected

If custom service is selected, no service is actually set in the uci config.
Fallback to custom service if no service is detected in the config.

Fixes #4301

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---

diff --git a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
index 93106db62b..2ea4cd2d4a 100644
--- a/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
+++ b/applications/luci-app-ddns/htdocs/luci-static/resources/view/ddns/overview.js
@@ -486,7 +486,7 @@ return L.view.extend({
 		o.value('-',"-- " + _("custom") + " --");
 
 		o.cfgvalue = function(section_id) {
-			return uci.get('ddns', section_id, 'service_name');
+			return uci.get('ddns', section_id, 'service_name') || '-';
 		}
 
 		o.write = function(section_id, formvalue) {