From: David Härdeman <david@hardeman.nu>
Date: Sat, 4 Oct 2025 17:50:17 +0000 (+0200)
Subject: ubus: minor correctness fix
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=57495fc4c3d3cb646234aac9191665847df18711;p=project%2Fodhcpd.git

ubus: minor correctness fix

Now, blobmsg_close_table() and blobmsg_close_array() happen to be identical, so
the actual code doesn't change at all, but this still caused me some
headscratching when I first saw it.

Signed-off-by: David Härdeman <david@hardeman.nu>
Link: https://github.com/openwrt/odhcpd/pull/267
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---

diff --git a/src/ubus.c b/src/ubus.c
index 82c5806..13a74cc 100644
--- a/src/ubus.c
+++ b/src/ubus.c
@@ -161,7 +161,7 @@ static int handle_dhcpv6_leases(_unused struct ubus_context *ctx, _unused struct
 
 			m = blobmsg_open_array(&b, a->flags & OAF_DHCPV6_NA ? "ipv6-addr": "ipv6-prefix");
 			dhcpv6_ia_enum_addrs(iface, a, now, dhcpv6_blobmsg_ia_addr, NULL);
-			blobmsg_close_table(&b, m);
+			blobmsg_close_array(&b, m);
 
 			blobmsg_add_u32(&b, "valid", INFINITE_VALID(a->valid_until) ?
 						(uint32_t)-1 : (uint32_t)(a->valid_until - now));