From: Paul Donald <newtwen+github@gmail.com>
Date: Wed, 23 Apr 2025 12:03:50 +0000 (+0200)
Subject: luci-app-ddns: Fix multiple IP display bug
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=54192d3b3659e0ef94c976c84f71f85efdb4528d;p=project%2Fluci.git

luci-app-ddns: Fix multiple IP display bug

Occasionally, a DNS lookup returns multiple IPs, so the best thing to
do isn't to join them together as a unified string, but to separate
them with an HTML <br/>.

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
---

diff --git a/applications/luci-app-ddns/root/usr/share/rpcd/ucode/ddns.uc b/applications/luci-app-ddns/root/usr/share/rpcd/ucode/ddns.uc
index b339528001..ad959a447b 100644
--- a/applications/luci-app-ddns/root/usr/share/rpcd/ucode/ddns.uc
+++ b/applications/luci-app-ddns/root/usr/share/rpcd/ucode/ddns.uc
@@ -178,7 +178,7 @@ const methods = {
 				}
 
 				res[section] = {
-					ip: ip ? replace(ip, '\n', '') : null,
+					ip: ip ? replace(trim(ip), '\n', '<br/>') : null,
 					last_update: lastUpdate !== 0 ? convertedLastUpdate : null,
 					next_update: nextUpdate || null,
 					pid: pid || null,