From: Felix Fietkau <nbd@nbd.name>
Date: Thu, 25 Aug 2022 10:37:24 +0000 (+0200)
Subject: unet-cli: pass service object to set_service()
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=2c23deaf9c1e321e0f906dc6336ba50cabbae7a2;p=project%2Funetd.git

unet-cli: pass service object to set_service()

Avoids accessing global net_data from within the function

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/scripts/unet-cli b/scripts/unet-cli
index 96894a3..f00c817 100755
--- a/scripts/unet-cli
+++ b/scripts/unet-cli
@@ -227,9 +227,7 @@ function set_host(name) {
 	});
 }
 
-function set_service(name) {
-	let service = net_data.services[name];
-
+function set_service(service) {
 	set_fields(service, {
 		type: "string",
 		members: "array",
@@ -388,12 +386,12 @@ case 'add-service':
 		members: [],
 	};
 	assert(args.type, "Missing service type");
-	set_service(servicename);
+	set_service(net_data.services[servicename]);
 	break;
 
 case 'set-service':
 	assert(net_data.services[servicename], `Service '${servicename}' does not exist`);
-	set_service(servicename);
+	set_service(net_data.services[servicename]);
 	break;
 
 default: