projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e0e52d4
)
[media] qt1010: signedness bug in qt1010_init_meas1()
author
Dan Carpenter
<
[email protected]
>
Fri, 10 Aug 2012 08:25:03 +0000
(
05:25
-0300)
committer
Mauro Carvalho Chehab
<
[email protected]
>
Sun, 12 Aug 2012 16:21:06 +0000
(13:21 -0300)
qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.
Signed-off-by: Dan Carpenter <
[email protected]
>
Acked-by: Antti Palosaari <
[email protected]
>
Signed-off-by: Mauro Carvalho Chehab <
[email protected]
>
drivers/media/common/tuners/qt1010.c
patch
|
blob
|
history
diff --git
a/drivers/media/common/tuners/qt1010.c
b/drivers/media/common/tuners/qt1010.c
index 2d79b1f5d5ebcebe9a00321ee278239ca64d0a7f..bdc39e11030ea8ddd5d9634c8d41b8ed0f26e983 100644
(file)
--- a/
drivers/media/common/tuners/qt1010.c
+++ b/
drivers/media/common/tuners/qt1010.c
@@
-288,7
+288,7
@@
static int qt1010_init_meas1(struct qt1010_priv *priv,
return qt1010_writereg(priv, 0x1e, 0x00);
}
-static
u8
qt1010_init_meas2(struct qt1010_priv *priv,
+static
int
qt1010_init_meas2(struct qt1010_priv *priv,
u8 reg_init_val, u8 *retval)
{
u8 i, val;