module: don't call percpu_modfree on NULL pointer.

The general one handles NULL, the static obsolescent
(CONFIG_HAVE_LEGACY_PER_CPU_AREA) one in module.c doesn't; Eric's
commit 720eba31 assumed it did, and various frobbings since then kept
that assumption.

All other callers in module.c all protect it with an if; this effectively
does the same as free_init is only goto if we fail percpu_modalloc().

Reported-by: Kamalesh Babulal <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Américo Wang <[email protected]>
Tested-by: Kamalesh Babulal <[email protected]>

diff --git a/kernel/module.c b/kernel/module.c
index c54f10d90e1c9fc69b47727c948fc36891148510..5a29397ca4b6f1633e91b8b94cfdac14f2071ff9 100644 (file)
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2523,8 +2523,8 @@ static noinline struct module *load_module(void __user *umod,
  free_unload:
        module_unload_free(mod);
 #if defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP)
- free_init:
        percpu_modfree(mod->refptr);
+ free_init:
 #endif
        module_free(mod, mod->module_init);
  free_core: