ath9k_htc: Fix HTC layer memleak

Messages that are generated by the HTC layer
don't have any TX callback endpoints assigned to them.
Consequently, the allocated SKBs are never freed.

Fix this issue by handling this case in the HTC layer
itself.

Signed-off-by: Sujith <[email protected]>
Signed-off-by: John W. Linville <[email protected]>

diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index 30f608bfc5671c3f1f9c34e6cc3b7bc2a69a667d..24d7b886fe233a8095ec544cc9358c51c3c43913 100644 (file)
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -326,11 +326,13 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle,
        if (htc_handle->htc_flags & HTC_OP_CONFIG_PIPE_CREDITS) {
                complete(&htc_handle->cmd_wait);
                htc_handle->htc_flags &= ~HTC_OP_CONFIG_PIPE_CREDITS;
+               goto ret;
        }
 
        if (htc_handle->htc_flags & HTC_OP_START_WAIT) {
                complete(&htc_handle->cmd_wait);
                htc_handle->htc_flags &= ~HTC_OP_START_WAIT;
+               goto ret;
        }
 
        if (skb) {
@@ -343,6 +345,11 @@ void ath9k_htc_txcompletion_cb(struct htc_target *htc_handle,
                                                  htc_hdr->endpoint_id, txok);
                }
        }
+
+       return;
+ret:
+       /* HTC-generated packets are freed here. */
+       dev_kfree_skb_any(skb);
 }
 
 /*