[media] omap3isp: video: Validate the video node field order
authorLaurent Pinchart <[email protected]>
Mon, 19 May 2014 15:14:42 +0000 (12:14 -0300)
committerMauro Carvalho Chehab <[email protected]>
Thu, 21 Aug 2014 20:25:13 +0000 (15:25 -0500)
The field order requested on the video node must match the field order
at the connected subdevice source pad.

Signed-off-by: Laurent Pinchart <[email protected]>
Tested-by: Enrico Butera <[email protected]>
Acked-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
drivers/media/platform/omap3isp/ispvideo.c

index 2fe1c463232d6b02219cb09c0dc8ca7772ec8de5..756c1628ef86dd0b46014278b033cf949f3d6b56 100644 (file)
@@ -309,10 +309,11 @@ isp_video_check_format(struct isp_video *video, struct isp_video_fh *vfh)
            vfh->format.fmt.pix.height != format.fmt.pix.height ||
            vfh->format.fmt.pix.width != format.fmt.pix.width ||
            vfh->format.fmt.pix.bytesperline != format.fmt.pix.bytesperline ||
-           vfh->format.fmt.pix.sizeimage != format.fmt.pix.sizeimage)
+           vfh->format.fmt.pix.sizeimage != format.fmt.pix.sizeimage ||
+           vfh->format.fmt.pix.field != format.fmt.pix.field)
                return -EINVAL;
 
-       return ret;
+       return 0;
 }
 
 /* -----------------------------------------------------------------------------