cls_flower: Fix comparing of old filter mask with new filter

We incorrectly compare the mask and the result is that we can't modify
an already existing rule.

Fix that by comparing correctly.

Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
Reported-by: Vlad Buslov <[email protected]>
Reviewed-by: Roi Dayan <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Signed-off-by: Paul Blakey <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 159efd98ee9ab2a4e728813d24f0f1ee0c486dc9..2b5be42a9f1ca8e63952158ed2b9339e1a308d0b 100644 (file)
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -877,7 +877,7 @@ static int fl_check_assign_mask(struct cls_fl_head *head,
                        return PTR_ERR(newmask);
 
                fnew->mask = newmask;
-       } else if (fold && fold->mask == fnew->mask) {
+       } else if (fold && fold->mask != fnew->mask) {
                return -EINVAL;
        }