projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
92b2e5b
)
XFS: xfs_trans_add_item() - don't assign in ASSERT() when compare is intended
author
Jesper Juhl
<
[email protected]
>
Mon, 13 Feb 2012 20:51:05 +0000
(20:51 +0000)
committer
Ben Myers
<
[email protected]
>
Mon, 13 Feb 2012 23:09:21 +0000
(17:09 -0600)
It looks to me like the two ASSERT()s in xfs_trans_add_item() really
want to do a compare (==) rather than assignment (=).
This patch changes it from the latter to the former.
Signed-off-by: Jesper Juhl <
[email protected]
>
Signed-off-by: Ben Myers <
[email protected]
>
(cherry picked from commit
05293485a0b6b1f803e8a3c0ff188c38f6969985
)
fs/xfs/xfs_trans.c
patch
|
blob
|
history
diff --git
a/fs/xfs/xfs_trans.c
b/fs/xfs/xfs_trans.c
index 329b06aba1c2c59ab1b973a3a956a3af23c68abf..7adcdf15ae0ce563b32eb37582fbdd79a8fdba15 100644
(file)
--- a/
fs/xfs/xfs_trans.c
+++ b/
fs/xfs/xfs_trans.c
@@
-1151,8
+1151,8
@@
xfs_trans_add_item(
{
struct xfs_log_item_desc *lidp;
- ASSERT(lip->li_mountp = tp->t_mountp);
- ASSERT(lip->li_ailp = tp->t_mountp->m_ail);
+ ASSERT(lip->li_mountp =
=
tp->t_mountp);
+ ASSERT(lip->li_ailp =
=
tp->t_mountp->m_ail);
lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS);