perf hists: Do not pass period and weight to add_hist_entry()
authorNamhyung Kim <[email protected]>
Wed, 18 Dec 2013 05:21:11 +0000 (14:21 +0900)
committerArnaldo Carvalho de Melo <[email protected]>
Wed, 18 Dec 2013 17:44:05 +0000 (14:44 -0300)
The @entry argument already has the info so no need to pass them.

Signed-off-by: Namhyung Kim <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Arun Sharma <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Rodrigo Campos <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
tools/perf/util/hist.c

index 822903eaa201f3ec81648206eaf3c2f3ae2710c0..63234e37583cc61abb3ea0a38bafd187d648a0e3 100644 (file)
@@ -342,15 +342,15 @@ static u8 symbol__parent_filter(const struct symbol *parent)
 }
 
 static struct hist_entry *add_hist_entry(struct hists *hists,
-                                     struct hist_entry *entry,
-                                     struct addr_location *al,
-                                     u64 period,
-                                     u64 weight)
+                                        struct hist_entry *entry,
+                                        struct addr_location *al)
 {
        struct rb_node **p;
        struct rb_node *parent = NULL;
        struct hist_entry *he;
        int64_t cmp;
+       u64 period = entry->stat.period;
+       u64 weight = entry->stat.weight;
 
        p = &hists->entries_in->rb_node;
 
@@ -437,7 +437,7 @@ struct hist_entry *__hists__add_entry(struct hists *hists,
                .transaction = transaction,
        };
 
-       return add_hist_entry(hists, &entry, al, period, weight);
+       return add_hist_entry(hists, &entry, al);
 }
 
 int64_t