regmap: core: allow a virtual range to cover its own data window
authorPhilipp Zabel <[email protected]>
Tue, 23 Jul 2013 10:16:02 +0000 (12:16 +0200)
committerMark Brown <[email protected]>
Tue, 6 Aug 2013 17:33:59 +0000 (18:33 +0100)
I see no reason why a virtual range shouldn't be allowed to cover its
own data window if the page selection register is in the same place
on every page.
For chips which use paged access for all of their registers, but only
when connected via I2C, and which can access the whole register space
directly when connected via SPI, this allows to avoid acrobatics with
the register ranges by simply mapping the I2C ranges over the data
window beginning at 0x0, and then using linear access for the SPI
variant.

Signed-off-by: Philipp Zabel <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
drivers/base/regmap/regmap.c

index e0d0c7d8a5c527867fb4ba05f4f21e74c43fcff2..436fac05b3b619511017781358b39031acade35f 100644 (file)
@@ -687,6 +687,10 @@ skip_format_initialization:
                        unsigned win_max = win_min +
                                           config->ranges[j].window_len - 1;
 
+                       /* Allow data window inside its own virtual range */
+                       if (j == i)
+                               continue;
+
                        if (range_cfg->range_min <= sel_reg &&
                            sel_reg <= range_cfg->range_max) {
                                dev_err(map->dev,