ipv6: esp6: use BUG_ON instead of if condition followed by BUG

Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
Acked-by: Herbert Xu <[email protected]>
Signed-off-by: Steffen Klassert <[email protected]>

diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
index 1696401fed6cbc0c9b6a57fd854bd3e5c309540a..4000b71bfdc5757c554e8964722417cad1a729e1 100644 (file)
--- a/net/ipv6/esp6.c
+++ b/net/ipv6/esp6.c
@@ -483,8 +483,8 @@ static inline int esp_remove_trailer(struct sk_buff *skb)
                goto out;
        }
 
-       if (skb_copy_bits(skb, skb->len - alen - 2, nexthdr, 2))
-               BUG();
+       ret = skb_copy_bits(skb, skb->len - alen - 2, nexthdr, 2);
+       BUG_ON(ret);
 
        ret = -EINVAL;
        padlen = nexthdr[0];