[PATCH] Skip check for mandatory locks when unlocking
authorSachin Prabhu <[email protected]>
Wed, 10 Mar 2010 15:28:40 +0000 (10:28 -0500)
committerJoel Becker <[email protected]>
Wed, 17 Mar 2010 19:07:16 +0000 (12:07 -0700)
ocfs2_lock() will skip locks on file which has mode set to 02666. This
is a problem in cases where the mode of the file is changed after a
process has obtained a lock on the file.

ocfs2_lock() should skip the check for mandatory locks when unlocking a
file.

Signed-off-by: Sachin Prabhu <[email protected]>
Signed-off-by: Joel Becker <[email protected]>
fs/ocfs2/locks.c

index 544ac6245175f26c23249cf916c5001ae8f5d067..b5cb3ede9408944d99abc7c7c3b28c01b1ddadeb 100644 (file)
@@ -133,7 +133,7 @@ int ocfs2_lock(struct file *file, int cmd, struct file_lock *fl)
 
        if (!(fl->fl_flags & FL_POSIX))
                return -ENOLCK;
-       if (__mandatory_lock(inode))
+       if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK)
                return -ENOLCK;
 
        return ocfs2_plock(osb->cconn, OCFS2_I(inode)->ip_blkno, file, cmd, fl);