ASoC: Intel: Skylake: remove bogus comparison of an array with NULL
authorAlan Cox <[email protected]>
Mon, 22 Feb 2016 04:07:27 +0000 (09:37 +0530)
committerMark Brown <[email protected]>
Mon, 22 Feb 2016 04:45:55 +0000 (13:45 +0900)
dfw_ac->params is an array not a pointer. It will never be NULL. The check
on ac->max appears sufficient.

Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
sound/soc/intel/skylake/skl-topology.c

index ba0d02d1613e04407e514469c05d7d39d7f58d30..c95bbce8ad5d3dda1ce28cc48c80e80ba129c11b 100644 (file)
@@ -1657,8 +1657,7 @@ static int skl_init_algo_data(struct device *dev, struct soc_bytes_ext *be,
                if (!ac->params)
                        return -ENOMEM;
 
-               if (dfw_ac->params)
-                       memcpy(ac->params, dfw_ac->params, ac->max);
+               memcpy(ac->params, dfw_ac->params, ac->max);
        }
 
        be->dobj.private  = ac;