ALSA: dice: fix a bounds check in snd_dice_detect_tcelectronic_formats()

The "entry" pointer is always non-NULL so this test for out of bounds
won't work.

Fixes: f1f0f330b1d0 ("ALSA: dice: add parameters of stream formats for models produced by TC Electronic")
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>

diff --git a/sound/firewire/dice/dice-tcelectronic.c b/sound/firewire/dice/dice-tcelectronic.c
index af8203b9d1a634c5928590418fac9b74ac5ae263..e134a5110c6c04c309f468772c03a7b67761dc7d 100644 (file)
--- a/sound/firewire/dice/dice-tcelectronic.c
+++ b/sound/firewire/dice/dice-tcelectronic.c
@@ -75,13 +75,12 @@ int snd_dice_detect_tcelectronic_formats(struct snd_dice *dice)
                }
        }
 
-       entry = NULL;
        for (i = 0; i < ARRAY_SIZE(entries); ++i) {
                entry = entries + i;
                if (entry->model_id == model_id)
                        break;
        }
-       if (!entry)
+       if (i == ARRAY_SIZE(entries))
                return -ENODEV;
 
        memcpy(dice->tx_pcm_chs, entry->spec->tx_pcm_chs,