ltq-atm: fix missing-prototypes warnings for lantiq/ase
authorShiji Yang <[email protected]>
Sat, 10 May 2025 09:19:18 +0000 (17:19 +0800)
committerRobert Marko <[email protected]>
Tue, 13 May 2025 20:02:20 +0000 (22:02 +0200)
This patch fixes various missing-prototypes build warnings on
6.12 kernel.

/home/db/owrt/build_dir/target-mips_24kc_musl/linux-lantiq_ase/ltq-atm-ase/ltq-atm/ifxmips_atm_amazon_se.c:257:13: error: no previous prototype for 'ase_fw_ver' [-Werror=missing-prototypes]
  257 | extern void ase_fw_ver(unsigned int *major, unsigned int *minor)
      |             ^~~~~~~~~~
/home/db/owrt/build_dir/target-mips_24kc_musl/linux-lantiq_ase/ltq-atm-ase/ltq-atm/ifxmips_atm_amazon_se.c:266:5: error: no previous prototype for 'ase_init' [-Werror=missing-prototypes]
  266 | int ase_init(struct platform_device *pdev)
      |     ^~~~~~~~
/home/db/owrt/build_dir/target-mips_24kc_musl/linux-lantiq_ase/ltq-atm-ase/ltq-atm/ifxmips_atm_amazon_se.c:283:6: error: no previous prototype for 'ase_shutdown' [-Werror=missing-prototypes]
  283 | void ase_shutdown(void)
      |      ^~~~~~~~~~~~
/home/db/owrt/build_dir/target-mips_24kc_musl/linux-lantiq_ase/ltq-atm-ase/ltq-atm/ifxmips_atm_amazon_se.c:297:5: error: no previous prototype for 'ase_start' [-Werror=missing-prototypes]
  297 | int ase_start(int pp32)
      |     ^~~~~~~~~
/home/db/owrt/build_dir/target-mips_24kc_musl/linux-lantiq_ase/ltq-atm-ase/ltq-atm/ifxmips_atm_amazon_se.c:323:6: error: no previous prototype for 'ase_stop' [-Werror=missing-prototypes]
  323 | void ase_stop(int pp32)
      |      ^~~~~~~~

Signed-off-by: Shiji Yang <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/18744
Signed-off-by: Robert Marko <[email protected]>
package/kernel/lantiq/ltq-atm/src/ifxmips_atm_amazon_se.c

index 0c6d9c101a7366463825b2e9e89b3cbf20df851e..c51f34dda3a0bc5002398112e1fed7b66632ef09 100644 (file)
@@ -254,7 +254,7 @@ static inline int pp32_download_code(u32 *code_src, unsigned int code_dword_len,
  * ####################################
  */
 
-extern void ase_fw_ver(unsigned int *major, unsigned int *minor)
+static void ase_fw_ver(unsigned int *major, unsigned int *minor)
 {
     ASSERT(major != NULL, "pointer is NULL");
     ASSERT(minor != NULL, "pointer is NULL");
@@ -263,7 +263,7 @@ extern void ase_fw_ver(unsigned int *major, unsigned int *minor)
     *minor = FW_VER_ID->minor;
 }
 
-int ase_init(struct platform_device *pdev)
+static int ase_init(struct platform_device *pdev)
 {
     init_pmu();
 
@@ -280,7 +280,7 @@ int ase_init(struct platform_device *pdev)
     return 0;
 }
 
-void ase_shutdown(void)
+static void ase_shutdown(void)
 {
     uninit_pmu();
 }
@@ -294,7 +294,7 @@ void ase_shutdown(void)
  *    int  --- 0: Success
  *             else:        Error Code
  */
-int ase_start(int pp32)
+static int ase_start(int pp32)
 {
     int ret;
 
@@ -320,7 +320,7 @@ int ase_start(int pp32)
  *  Output:
  *    none
  */
-void ase_stop(int pp32)
+static void ase_stop(int pp32)
 {
     /*  halt PP32   */
     IFX_REG_W32(DBG_CTRL_STOP, PP32_DBG_CTRL);