projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9ac1353
)
skge: Fix skge_set_ring_param() losing error return
author
Wang Chen
<
[email protected]
>
Fri, 26 Sep 2008 08:20:32 +0000
(16:20 +0800)
committer
David S. Miller
<
[email protected]
>
Wed, 8 Oct 2008 23:02:40 +0000
(16:02 -0700)
The error return is useful to caller, driver shouldn't miss it.
Signed-off-by: Wang Chen <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/skge.c
patch
|
blob
|
history
diff --git
a/drivers/net/skge.c
b/drivers/net/skge.c
index 3bca52c142fe8a10e1e47dd5267bd34c12d0ce53..43f4c730be42546b8be59f1f97127f2d0ef06a3a 100644
(file)
--- a/
drivers/net/skge.c
+++ b/
drivers/net/skge.c
@@
-501,7
+501,7
@@
static int skge_set_ring_param(struct net_device *dev,
struct ethtool_ringparam *p)
{
struct skge_port *skge = netdev_priv(dev);
- int err;
+ int err
= 0
;
if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE ||
p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE)
@@
-517,7
+517,7
@@
static int skge_set_ring_param(struct net_device *dev,
dev_close(dev);
}
- return
0
;
+ return
err
;
}
static u32 skge_get_msglevel(struct net_device *netdev)