realtek: Switch booleans in rtl838x_port to single bits
authorSven Eckelmann <[email protected]>
Thu, 9 Oct 2025 11:56:19 +0000 (13:56 +0200)
committerRobert Marko <[email protected]>
Sun, 12 Oct 2025 10:49:49 +0000 (12:49 +0200)
In upstream kernel, it is not well received to use a lot of simple booleans
in structs. It is preferred to use 1-bit bitfields [1] and consolidate the
booleans together.

[1] https://www.kernel.org/doc/html/v6.16/process/coding-style.html#using-bool

Signed-off-by: Sven Eckelmann <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/20360
Signed-off-by: Robert Marko <[email protected]>
target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl838x.h

index 91024422311237a8a7778179932d14a358af659c..42b1911d9e3ae962a108e04f059aabac6b9ab1b3 100644 (file)
@@ -680,14 +680,14 @@ struct rtldsa_counter_state {
 };
 
 struct rtl838x_port {
-       bool enable;
+       bool enable:1;
+       bool phy_is_integrated:1;
+       bool is10G:1;
+       bool is2G5:1;
        u64 pm;
        u16 pvid;
        bool eee_enabled;
        enum phy_type phy;
-       bool phy_is_integrated;
-       bool is10G;
-       bool is2G5;
        int sds_num;
        int led_set;
        int leds_on_this_port;