luci-mod-network: add odhcpd cfg in DHCP server setup
authorDavid Härdeman <[email protected]>
Sat, 25 Oct 2025 22:02:32 +0000 (00:02 +0200)
committerPaul Donald <[email protected]>
Sun, 26 Oct 2025 03:11:06 +0000 (04:11 +0100)
The "Set up DHCP Server" button is meant to setup the basics for a DHCP server
on the given interface.  Add odhcpd setting "dhcpv4" as well. It is a no-op in
case odhcpd isn't setup to take care of DHCPv4 as well, but it makes it easier
to support either dnsmasq or odhpcd as the DHCPv4 server.

One might argue that the button should also set dhcpv6=server and ra=server, so
that it doesn't only setup a DHCPv4 server, but also prepares a DHCPv6 server,
but that's for another PR :)

Signed-off-by: David Härdeman <[email protected]>
modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js

index 347adea58568a8bd667730b5ceb8f6bd9e31cde2..a949ccb7b32a03be144b33825c21bb4fbf7a5b07 100644 (file)
@@ -691,8 +691,8 @@ return view.extend({
                                                                                        uci.set('dhcp', section_id, 'start', 100);
                                                                                        uci.set('dhcp', section_id, 'limit', 150);
                                                                                        uci.set('dhcp', section_id, 'leasetime', '12h');
-                                                                               }
-                                                                               else {
+                                                                                       uci.set('dhcp', section_id, 'dhcpv4', 'server');
+                                                                               else {
                                                                                        uci.set('dhcp', section_id, 'ignore', 1);
                                                                                }
                                                                        });