tools/lib/traceevent/parse-filter.c: clean up clang build warning
authorCheng Jian <[email protected]>
Fri, 17 Nov 2017 23:28:23 +0000 (15:28 -0800)
committerLinus Torvalds <[email protected]>
Sat, 18 Nov 2017 00:10:02 +0000 (16:10 -0800)
The uniform structure filter_arg sets its union based on the difference
of enum filter_arg_type, However, some functions use implicit type
conversion obviously.

warning: implicit conversion from enumeration type 'enum filter_exp_type'
 to different enumeration type 'enum filter_op_type'

warning: implicit conversion from enumeration type 'enum filter_cmp_type'
 to different enumeration type 'enum filter_exp_type'

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Cheng Jian <[email protected]>
Cc: Kate Stewart <[email protected]>
Cc: Xie XiuQi <[email protected]>
Cc: Li Bin <[email protected]>
Cc: Steven Rostedt (Red Hat) <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
tools/lib/traceevent/parse-filter.c

index 7c214ceb93860abea126f086da2e4e823417fc01..315df0a70265291f2752ab5248e36b32a3e956b7 100644 (file)
@@ -436,13 +436,13 @@ create_arg_exp(enum filter_exp_type etype)
                return NULL;
 
        arg->type = FILTER_ARG_EXP;
-       arg->op.type = etype;
+       arg->exp.type = etype;
 
        return arg;
 }
 
 static struct filter_arg *
-create_arg_cmp(enum filter_exp_type etype)
+create_arg_cmp(enum filter_cmp_type ctype)
 {
        struct filter_arg *arg;
 
@@ -452,7 +452,7 @@ create_arg_cmp(enum filter_exp_type etype)
 
        /* Use NUM and change if necessary */
        arg->type = FILTER_ARG_NUM;
-       arg->op.type = etype;
+       arg->num.type = ctype;
 
        return arg;
 }