projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4bbd1a1
)
hisax: timeout off by one in waitrecmsg()
author
Roel Kluin
<
[email protected]
>
Tue, 2 Feb 2010 12:43:44 +0000
(12:43 +0000)
committer
David S. Miller
<
[email protected]
>
Thu, 4 Feb 2010 04:16:46 +0000
(20:16 -0800)
With `while (timeout++ < maxdelay)' timeout reaches maxdelay + 1 after the
loop This is probably unlikely a problem in practice.
Signed-off-by: Roel Kluin <
[email protected]
>
Cc: Karsten Keil <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/isdn/hisax/isar.c
patch
|
blob
|
history
diff --git
a/drivers/isdn/hisax/isar.c
b/drivers/isdn/hisax/isar.c
index bfeb9b6aa04370e118f9eee04d0d29a454fb03d3..6bde16c00fb53c8e0959f1d3a05a294f77da5cfa 100644
(file)
--- a/
drivers/isdn/hisax/isar.c
+++ b/
drivers/isdn/hisax/isar.c
@@
-138,7
+138,7
@@
waitrecmsg(struct IsdnCardState *cs, u_char *len,
while((!(cs->BC_Read_Reg(cs, 0, ISAR_IRQBIT) & ISAR_IRQSTA)) &&
(timeout++ < maxdelay))
udelay(1);
- if (timeout >
=
maxdelay) {
+ if (timeout > maxdelay) {
printk(KERN_WARNING"isar recmsg IRQSTA timeout\n");
return(0);
}