ocfs2: flock: drop cross-node lock when failed locally

ocfs2_do_flock() calls ocfs2_file_lock() to get the cross-node clock and
then call flock_lock_file_wait() to compete with local processes.  In
case flock_lock_file_wait() failed, say -ENOMEM, clean up work is not
done.  This patch adds the cleanup --drop the cross-node lock which was
just granted.

[[email protected]: coding-style fixes]
Signed-off-by: Wengang Wang <[email protected]>
Cc: Joel Becker <[email protected]>
Reviewed-by: Mark Fasheh <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/fs/ocfs2/locks.c b/fs/ocfs2/locks.c
index e57c804069ea6487c0a8eba6d203f88ccd8dd39a..6b6d092b09985941f856671722d6db52e1fd035d 100644 (file)
--- a/fs/ocfs2/locks.c
+++ b/fs/ocfs2/locks.c
@@ -82,6 +82,8 @@ static int ocfs2_do_flock(struct file *file, struct inode *inode,
        }
 
        ret = flock_lock_file_wait(file, fl);
+       if (ret)
+               ocfs2_file_unlock(file);
 
 out:
        mutex_unlock(&fp->fp_mutex);