is_power_of_2 in fs/hfs
authorVignesh Babu BM <[email protected]>
Tue, 8 May 2007 07:24:30 +0000 (00:24 -0700)
committerLinus Torvalds <[email protected]>
Tue, 8 May 2007 18:14:59 +0000 (11:14 -0700)
Replace (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by: vignesh babu <[email protected]>
Cc: Roman Zippel <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/hfs/btree.c
fs/hfsplus/btree.c

index 5fd0ed71f92331c3553ef9d563c0543e9fc9e9f6..8a3a650abc87a9ed4520318a811fb76619933a7e 100644 (file)
@@ -9,6 +9,7 @@
  */
 
 #include <linux/pagemap.h>
+#include <linux/log2.h>
 
 #include "btree.h"
 
@@ -76,7 +77,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp ke
        tree->depth = be16_to_cpu(head->depth);
 
        size = tree->node_size;
-       if (!size || size & (size - 1))
+       if (!is_power_of_2(size))
                goto fail_page;
        if (!tree->node_count)
                goto fail_page;
index a9b9e872e29a6296ecd4d327bd8f2653beeb7a3e..90ebab753d306d8da95227644ab24480ef8649ca 100644 (file)
@@ -10,6 +10,7 @@
 
 #include <linux/slab.h>
 #include <linux/pagemap.h>
+#include <linux/log2.h>
 
 #include "hfsplus_fs.h"
 #include "hfsplus_raw.h"
@@ -69,7 +70,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id)
        }
 
        size = tree->node_size;
-       if (!size || size & (size - 1))
+       if (!is_power_of_2(size))
                goto fail_page;
        if (!tree->node_count)
                goto fail_page;