fs, omfs: add NULL terminator in the end up the token list
authorSasha Levin <[email protected]>
Thu, 28 May 2015 22:44:29 +0000 (15:44 -0700)
committerLinus Torvalds <[email protected]>
Fri, 29 May 2015 01:25:18 +0000 (18:25 -0700)
match_token() expects a NULL terminator at the end of the token list so
that it would know where to stop.  Not having one causes it to overrun
to invalid memory.

In practice, passing a mount option that omfs didn't recognize would
sometimes panic the system.

Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Bob Copeland <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/omfs/inode.c

index 138321b0c6c2b95a8efcef1a5b3183f3126acbb9..70d4191cf33d4a3d875ff9c719b4f1b9c75d7f78 100644 (file)
@@ -359,7 +359,7 @@ nomem:
 }
 
 enum {
-       Opt_uid, Opt_gid, Opt_umask, Opt_dmask, Opt_fmask
+       Opt_uid, Opt_gid, Opt_umask, Opt_dmask, Opt_fmask, Opt_err
 };
 
 static const match_table_t tokens = {
@@ -368,6 +368,7 @@ static const match_table_t tokens = {
        {Opt_umask, "umask=%o"},
        {Opt_dmask, "dmask=%o"},
        {Opt_fmask, "fmask=%o"},
+       {Opt_err, NULL},
 };
 
 static int parse_options(char *options, struct omfs_sb_info *sbi)