drivers/rtc/rtc-tps65910.c: fix incorrect return value on error
authorSachin Kamat <[email protected]>
Mon, 29 Apr 2013 23:20:10 +0000 (16:20 -0700)
committerLinus Torvalds <[email protected]>
Tue, 30 Apr 2013 01:28:33 +0000 (18:28 -0700)
'ret' was not initialized to correct error value before returning.
Since 'irq' is also being tested for 0, we cannot return irq itself as
it means function is success even though we are returning before
completing the probe.

Signed-off-by: Sachin Kamat <[email protected]>
Acked-by: Venu Byravarasu <[email protected]>
Cc: Chiwoong Byun <[email protected]>
Cc: Jonghwa Lee <[email protected]>
Cc: Laxman dewangan <[email protected]>
Cc: Jingoo Han <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
drivers/rtc/rtc-tps65910.c

index 26b8bd25276918ee5ea24e107745d61a401aff71..a9caf043b0ce8716f495d437f3d2be9857b03885 100644 (file)
@@ -263,7 +263,7 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
        if (irq <= 0) {
                dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",
                        irq);
-               return ret;
+               return -ENXIO;
        }
 
        ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,