e1000e: stop cleaning when we reach tx_ring->next_to_use
authorTerry Loftin <[email protected]>
Fri, 9 Apr 2010 10:29:49 +0000 (10:29 +0000)
committerDavid S. Miller <[email protected]>
Tue, 13 Apr 2010 10:03:13 +0000 (03:03 -0700)
Tx ring buffers after tx_ring->next_to_use are volatile and could
change, possibly causing a crash.  Stop cleaning when we hit
tx_ring->next_to_use.

Signed-off-by: Terry Loftin <[email protected]>
Acked-by: Bruce Allan <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/e1000e/netdev.c

index cfd09cea721450e12483ee4b63206f24eaabb07f..73d43c53015a052efdbd3eacd4ba714a9b930bff 100644 (file)
@@ -661,6 +661,8 @@ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter)
                                i = 0;
                }
 
+               if (i == tx_ring->next_to_use)
+                       break;
                eop = tx_ring->buffer_info[i].next_to_watch;
                eop_desc = E1000_TX_DESC(*tx_ring, eop);
        }