drm/edid: shorten log output in case of all zeroes edid block

There is no need to dump the whole EDID block in case it contains no
information. Just print a single line stating the block is empty instead
of 8 lines containing only zeroes.

Signed-off-by: Stefan Brüns <[email protected]>
Reviewed-by: Jani Nikula <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index f8fb327407cd5414c5b8905324e1b7f7c5fe249b..a71ed935f1c47448f303bc3faebdd5210ccef5fe 100644 (file)
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1088,9 +1088,13 @@ bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid)
 
 bad:
        if (print_bad_edid) {
-               printk(KERN_ERR "Raw EDID:\n");
-               print_hex_dump(KERN_ERR, " \t", DUMP_PREFIX_NONE, 16, 1,
+               if (drm_edid_is_zero(raw_edid, EDID_LENGTH)) {
+                       printk(KERN_ERR "EDID block is all zeroes\n");
+               } else {
+                       printk(KERN_ERR "Raw EDID:\n");
+                       print_hex_dump(KERN_ERR, " \t", DUMP_PREFIX_NONE, 16, 1,
                               raw_edid, EDID_LENGTH, false);
+               }
        }
        return false;
 }