flow_dissector: do not rely on implicit casts

This change fixes a couple of type mismatch reported by the sparse
tool, explicitly using the requested type for the offending arguments.

Signed-off-by: Paolo Abeni <[email protected]>
Acked-by: Jon Maloy <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/include/net/tipc.h b/include/net/tipc.h
index 07670ec022a714bd9a675d2ffd89455f10a04a01..f0e7e6bc1befa83b0e23e9ef3d5c4855c5bd135f 100644 (file)
--- a/include/net/tipc.h
+++ b/include/net/tipc.h
@@ -44,11 +44,11 @@ struct tipc_basic_hdr {
        __be32 w[4];
 };
 
-static inline u32 tipc_hdr_rps_key(struct tipc_basic_hdr *hdr)
+static inline __be32 tipc_hdr_rps_key(struct tipc_basic_hdr *hdr)
 {
        u32 w0 = ntohl(hdr->w[0]);
        bool keepalive_msg = (w0 & KEEPALIVE_MSG_MASK) == KEEPALIVE_MSG_MASK;
-       int key;
+       __be32 key;
 
        /* Return source node identity as key */
        if (likely(!keepalive_msg))

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 030d4ca177fb1a0333a7e33c242c92c358b003ca..4fc1e84d77ec1d8469903463e2226fe667d4ece1 100644 (file)
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -1316,7 +1316,7 @@ u32 skb_get_poff(const struct sk_buff *skb)
 {
        struct flow_keys_basic keys;
 
-       if (!skb_flow_dissect_flow_keys_basic(skb, &keys, 0, 0, 0, 0, 0))
+       if (!skb_flow_dissect_flow_keys_basic(skb, &keys, NULL, 0, 0, 0, 0))
                return 0;
 
        return __skb_get_poff(skb, skb->data, &keys, skb_headlen(skb));