projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
702a98c
)
dc395x: decrease iteration for tag_number of max_command in start_scsi()
author
Roel Kluin
<
[email protected]
>
Wed, 11 Aug 2010 01:01:17 +0000
(18:01 -0700)
committer
Linus Torvalds
<
[email protected]
>
Wed, 11 Aug 2010 15:59:00 +0000
(08:59 -0700)
The tag_number reaches dcb->max_command + 1 after the loop, but when
the tag_number equals dcb->max_command an error message is already
issued. The last iteration therefore appears obsolete.
Signed-off-by: Roel Kluin <
[email protected]
>
Cc: Oliver Neukum <
[email protected]
>
Cc: James Bottomley <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: Linus Torvalds <
[email protected]
>
drivers/scsi/dc395x.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/dc395x.c
b/drivers/scsi/dc395x.c
index bd977be7544e37355c35b2addf55d02ef9747039..54f50b07dac7f36fe5950efb9bdaf34340d4bbed 100644
(file)
--- a/
drivers/scsi/dc395x.c
+++ b/
drivers/scsi/dc395x.c
@@
-1597,7
+1597,7
@@
static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
u32 tag_mask = 1;
u8 tag_number = 0;
while (tag_mask & dcb->tag_mask
- && tag_number <
=
dcb->max_command) {
+ && tag_number < dcb->max_command) {
tag_mask = tag_mask << 1;
tag_number++;
}