PCI: Fix reference count leak in pci_dev_present()

Function pci_get_dev_by_id() takes a reference on the pci_dev returned, so
pci_dev_present() should release the corresponding reference.

Signed-off-by: Jiang Liu <[email protected]>
Signed-off-by: Yinghai Lu <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Acked-by: Rafael J. Wysocki <[email protected]>

diff --git a/drivers/pci/search.c b/drivers/pci/search.c
index bf969ba58e59d10aa770909005bee01ac76dd060..d0627fa9f36827fdd864e462d519fd2279ef7d56 100644 (file)
--- a/drivers/pci/search.c
+++ b/drivers/pci/search.c
@@ -319,13 +319,13 @@ int pci_dev_present(const struct pci_device_id *ids)
        WARN_ON(in_interrupt());
        while (ids->vendor || ids->subvendor || ids->class_mask) {
                found = pci_get_dev_by_id(ids, NULL);
-               if (found)
-                       goto exit;
+               if (found) {
+                       pci_dev_put(found);
+                       return 1;
+               }
                ids++;
        }
-exit:
-       if (found)
-               return 1;
+
        return 0;
 }
 EXPORT_SYMBOL(pci_dev_present);